Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support like syntax in show tables statement #331

Merged
merged 42 commits into from
Nov 8, 2022
Merged

feat: support like syntax in show tables statement #331

merged 42 commits into from
Nov 8, 2022

Conversation

QuintinTao
Copy link
Contributor

@QuintinTao QuintinTao commented Oct 21, 2022 •
edited by jiacai2050
Loading

Which issue does this PR close?

Close #128

Rationale for this change

no

What changes are included in this PR?

Extend show tables statement

Are there any user-facing changes?

user can use show tables like 'abc' to search table

curl --location --request POST 'http://127.0.0.1:5440/sql' \
--header 'Content-Type: application/json' \
--data-binary '{
    "query": "show tables like 'abc%'"
}'

How does this change test

UT and integration test.

@jiacai2050
Copy link
Contributor

jiacai2050 commented Oct 21, 2022 •
edited
Loading

@QuintinTao Your PR's description doesn't follow our template, you can refer #330 to update yours, thanks.

@QuintinTao
Copy link
Contributor Author

@QuintinTao Your PR's description doesn't follow our template, you can refer #330 to update yours, thanks.

OK

@QuintinTao QuintinTao changed the title Show tables statement support like syntax chore: add like syntax in show tables statement Oct 21, 2022
jiacai2050
jiacai2050 requested changes Oct 21, 2022
View reviewed changes
sql/src/ast.rs Outdated Show resolved Hide resolved
interpreters/src/show.rs Outdated Show resolved Hide resolved
@jiacai2050
Copy link
Contributor

@QuintinTao A test is required, you can add a Integration test in

@QuintinTao
Copy link
Contributor Author

@QuintinTao A test is required, you can add a Integration test in

I replaced SHOW TABLES name LIKE '01_system_table1'; with SHOW TABLES LIKE '01%';
But it seems SHOW TABLES name LIKE '01_system_table1' already running.

@jiacai2050 jiacai2050 changed the title chore: add like syntax in show tables statement feat: support like syntax in show tables statement Oct 25, 2022
jiacai2050
jiacai2050 requested changes Oct 26, 2022
View reviewed changes
interpreters/src/show.rs Outdated Show resolved Hide resolved
interpreters/src/show.rs Outdated Show resolved Hide resolved
sql/src/ast.rs Outdated Show resolved Hide resolved
jiacai2050
jiacai2050 requested changes Nov 3, 2022
View reviewed changes
sql/src/parser.rs Outdated Show resolved Hide resolved
interpreters/src/show.rs Outdated Show resolved Hide resolved
interpreters/src/show.rs Outdated Show resolved Hide resolved
interpreters/src/show.rs Show resolved Hide resolved
jiacai2050
jiacai2050 approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 9699e85 into apache:main Nov 8, 2022
@jiacai2050
Copy link
Contributor

@QuintinTao Thanks for your hard work. 🚀

@jiacai2050 jiacai2050 mentioned this pull request Nov 8, 2022
Merged
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@QuintinTao
feat: support like syntax in show tables statement (apache#331)
a2b4b08 
* Show tables statement support like syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show tables statement support name like syntax
2 participants
@QuintinTao @jiacai2050